Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 70d3e5c

Browse files
committed
Merge pull request #7031 from adobe/rlim/save-sidebar-visibility
Save side bar visibility immediately when not in resizing.
2 parents aa40f85 + 3bc54ec commit 70d3e5c

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

src/utils/Resizer.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ define(function (require, exports, module) {
6464

6565
var $mainView;
6666

67+
var isResizing = false;
68+
6769
/**
6870
* Shows a resizable element.
6971
* @param {DOMNode} element Html element to show if possible
@@ -214,7 +216,7 @@ define(function (require, exports, module) {
214216
adjustSibling(elementSize);
215217

216218
$element.trigger("panelExpanded", [elementSize]);
217-
PreferencesManager.setViewState(elementID, elementPrefs, null, true);
219+
PreferencesManager.setViewState(elementID, elementPrefs, null, isResizing);
218220
});
219221

220222
$element.data("hide", function () {
@@ -236,7 +238,7 @@ define(function (require, exports, module) {
236238
adjustSibling(0);
237239

238240
$element.trigger("panelCollapsed", [elementSize]);
239-
PreferencesManager.setViewState(elementID, elementPrefs, null, true);
241+
PreferencesManager.setViewState(elementID, elementPrefs, null, isResizing);
240242
});
241243

242244
// If the resizer is positioned right or bottom of the panel, we need to listen to
@@ -255,9 +257,9 @@ define(function (require, exports, module) {
255257
newSize = startSize,
256258
previousSize = startSize,
257259
baseSize = 0,
258-
isMouseDown = true,
259260
resizeStarted = false;
260261

262+
isResizing = true;
261263
$body.append($resizeShield);
262264

263265
if ($resizableElement.length) {
@@ -273,7 +275,7 @@ define(function (require, exports, module) {
273275
function doRedraw() {
274276
// only run this if the mouse is down so we don't constantly loop even
275277
// after we're done resizing.
276-
if (!isMouseDown) {
278+
if (!isResizing) {
277279
return;
278280
}
279281

@@ -347,7 +349,7 @@ define(function (require, exports, module) {
347349
}
348350

349351
function endResize(e) {
350-
if (isMouseDown) {
352+
if (isResizing) {
351353

352354
var elementSize = elementSizeFunction.apply($element);
353355
if ($element.is(":visible")) {
@@ -359,7 +361,7 @@ define(function (require, exports, module) {
359361
repositionResizer(elementSize);
360362
}
361363

362-
isMouseDown = false;
364+
isResizing = false;
363365

364366
if (resizeStarted) {
365367
$element.trigger("panelResizeEnd", [elementSize]);

0 commit comments

Comments
 (0)