This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Save side bar visibility immediately when not in resizing.#7031
Merged
Save side bar visibility immediately when not in resizing.#7031
Conversation
Contributor
There was a problem hiding this comment.
It's not possible to hide/show while resizing, right? If so, isResizing will always be false so I think passing this as a param is misleading. This is an optional param that defaults to false, so this could simply be:
PreferencesManager.setViewState(elementID, elementPrefs, null);
Contributor
There was a problem hiding this comment.
Also, if so, the isResizing var does not need to be module scope.
Contributor
Author
There was a problem hiding this comment.
Yes, during resizing doRedraw() is called and it then calls toggle($element); which in turn triggers these two show/hide functions that is in module scope. So isResizing var needs to be in module scope.
Contributor
|
Done with initial review. |
Contributor
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Feb 28, 2014
Save side bar visibility immediately when not in resizing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #7030.