This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix: If first line in selection is a line comment, Block Comment does nothing #2121
Merged
redmunds merged 2 commits intoadobe:masterfrom Dec 5, 2012
TomMalbran:tom/fix-issue-2118
Merged
Fix: If first line in selection is a line comment, Block Comment does nothing #2121redmunds merged 2 commits intoadobe:masterfrom TomMalbran:tom/fix-issue-2118
redmunds merged 2 commits intoadobe:masterfrom
TomMalbran:tom/fix-issue-2118
Conversation
ghost
assigned
Contributor
|
Note that there's a typo in commit message. This is for #2118. |
Contributor
There was a problem hiding this comment.
This looks good. My only comment would be to break this condition on the && to make logic easier to read:
if (editor.posWithinRange(ctxPos, sel.start, sel.end) &&
(!endCtx.token.string.match(lineExp) || editor.indexFromPos(sel.end) >= endCtxIndex)) {
Contributor
Author
|
Yes. My mistake. The branch name and the pull name are still right. |
Contributor
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Dec 5, 2012
Fix: If first line in selection is a line comment, Block Comment does nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix would let you do a block-comment around a line-comments, if the selection includes all the content in the line-comments.
It stills has the line-uncomment for other cases.