This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Changing Block-Comment so that it doesn't replace the whole selection#2148
Merged
peterflynn merged 1 commit intoadobe:masterfrom Nov 21, 2012
TomMalbran:tom/fix-block-comment-replace
Merged
Changing Block-Comment so that it doesn't replace the whole selection#2148peterflynn merged 1 commit intoadobe:masterfrom TomMalbran:tom/fix-block-comment-replace
peterflynn merged 1 commit intoadobe:masterfrom
TomMalbran:tom/fix-block-comment-replace
Conversation
…he whole selection
ghost
assigned
Member
|
Thanks Tom, looks good! Merging... |
peterflynn
added a commit
that referenced
this pull request
Nov 21, 2012
Changing Block-Comment so that it inserts text at start & end instead of replacing the whole selected range.
Member
|
And this does indeed have a more gentle touch with bookmarks: if you open the new color editor on a color in CSS, you can now select a range of text on both sides of the colorpicker and comment/uncomment it without causing the colorpicker to close itself. |
Contributor
Author
|
Thanks. This was my first implementation (but not committed), abut then changed it to fix the undo problem, no knowing about the bookmarks. But now, this seems much better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a change commented in #2108
Now that batchOperation doesn't break the undo for multiple replace operations, is better that commenting just places the prefix and suffix, and not do only 1 replace with the content inside the selection plus the prefix and suffix. This pull fixes this.