[CLOSED] Changing Block-Comment so that it doesn't replace the whole selection

[core-ai-bot]

Issue by TomMalbran
Monday Nov 19, 2012 at 01:55 GMT
Originally opened as adobe/brackets#2148

---

This was a change commented in adobe/brackets#2108

Now that batchOperation doesn't break the undo for multiple replace operations, is better that commenting just places the prefix and suffix, and not do only 1 replace with the content inside the selection plus the prefix and suffix. This pull fixes this.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/2148/commits

[core-ai-bot]

Comment by peterflynn
Wednesday Nov 21, 2012 at 23:23 GMT

---

Thanks Tom, looks good! Merging...

[core-ai-bot]

Comment by peterflynn
Wednesday Nov 21, 2012 at 23:26 GMT

---

And this does indeed have a more gentle touch with bookmarks: if you open the new color editor on a color in CSS, you can now select a range of text on both sides of the colorpicker and comment/uncomment it without causing the colorpicker to close itself.

[core-ai-bot]

Comment by TomMalbran
Wednesday Nov 21, 2012 at 23:39 GMT

---

Thanks. This was my first implementation (but not committed), abut then changed it to fix the undo problem, no knowing about the bookmarks. But now, this seems much better.