Quick Open should keep selecting as arrow key held down, with wrap

[WebsiteDeveloper]

This happens in the current master build, when you open the quick open dropdown and press the ArrowDownKey and keep pressing it the quick open does't select anything at all.
It does only select the next item if you release the key.
In my opinion it should keep selecting the next item every moment.

[redmunds]

Another thing that weird about arrow key handling in Quick Open is that if you keep hitting down arrow after you reach the end of the list it wraps around back to the top, but if you keep pressing up arrow it stops at the top (i.e. doesn't wrap around). I don't really have a preference for wrapping or not, but I do think it should be consistent in both directions.

[WebsiteDeveloper]

yeah i absolutely agree

[peterflynn]

Both appear to be bugs/limitations of the 'smart autocomplete' library that we use. We should really ditch that lib at some point, as it's pretty constraining.

The problem with the key being held down occurs because smart autocomplete is listening for keyup, which doesn't fire during key repeat (unlike keydown/press).

[gruehle]

Reviewed. Marking "move to backlog". We should have a backlog item to replace Smart Autocomplete with something better.

[WebsiteDeveloper]

@peterflynn i fixed this issue in a pull to the main repo of the 'smart autocomplete' library so we just have to include the latest master to get that fix

[peterflynn]

Closing and tracking on feature backlog as part of Quick Open UI polish.

[peterflynn]

This is now fixed in 1.3 with the new dropdown implementation