Focus disappears when tabbing through dialog box elements

[lkcampbell]

OS: Windows 7

Build: sprint 28 development build 0.28.0-0 (master 0f93238)

This bug happens in all dialog boxes as far as I can tell but I am using the specific example of the Project Settings dialog box because it provides a good quality repro.

Repro Steps:

1. Open the Project Settings dialog box
2. Hit the Tab key three times, noting which dialog box element is highlighted each time.

Observed results:

When dialog box is opened, the URL text field is highlighted.
After first Tab, the Cancel button is highlighted.
After second Tab, the OK button is highlighted.
After third, nothing is highlighted. Any subsequent Tabs give the same result.

Expected results:

When dialog box is opened, the URL text field is highlighted.
After first Tab, the Cancel button is highlighted.
After second Tab, the OK button is highlighted.
After third, the URL text field is highlighted and the cycle continues from there.

[peterflynn]

This might be a fact of life with Bootstrap modals until we do real focus management.

[RaymondLim]

@peterflynn
Actually, it's not FOL. We just need to add some code to identify the first and last (enabled) elements in the dialog and explicitly link the tab loop between the last and the first element. I'm assigning this to myself.

[RaymondLim]

Set it to medium priority and nominate for sprint 29 since it is part of keyboard accessibility and affecting all dialogs used in Brackets.

[peterflynn]

@RaymondLim I'm confused why medium/29... we don't have any keyboard-specific work scheduled sprint, and this "feature" with dialogs has been around in every Brackets release we've ever shipped. IMHO it's low priority (if not MTB), and not urgent for any specific sprint...

But that doesn't preclude anyone from putting up a pull request as "bonus" work of course.

[adrocknaphobia]

I disagree with @peterflynn. I think this is a medium issue. Brackets is a keyboard-focused application, so this workflow needs to work. We're moving it out of Sprint 29 because we need more time to figure out how to fix this across all dialogs.

[peterflynn]

@adrocknaphobia The reason I'm arguing it's low is that the bug has existed for the entire lifespan of Brackets (18 months now?) and it was only just filed now -- so it seems pretty clear few users hit / are annoyed by this.

[njx]

Assigning to @TomMalbran and marking fix in progress since he has a pull request up.

[RaymondLim]

FBNC to @lkcampbell

[lkcampbell]

Confirmed that this is now working in the Project Settings dialog box.