You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
To mimic an installed build finding an update, make these changes in UpdateNotification:
Comment out the if (_buildNumber === 0 && !force) block (lines 275-278) -- so the block inside never runs
Comment out the if (force || allUpdates[0].buildNumber > _lastNotifiedBuildNumber) test (line 294) -- so the block inside always runs
or - alternative: just add force = true; at the top of checkForUpdate().
Reload Brackets
Result:
Update notification dialog appears but there's no dark gray "shield" behind it.
Blinking cursor is still in the editor area, and if you type it will modify the editor.
However, clicking/scrolling anywhere is still blocked, along with editor shortcuts like Ctrl+D or Ctrl+Z.
Hitting Esc still closes the dialog, but hitting Enter does not.
Expected:
Gray shield and all keystrokes go only to the dialog, same as if you show it via Help > Check for Updates.
I think the typing still working & the missing shield are both regressions due to PR #4714. Older builds may have shown a blinking cursor in the editor still, but I don't think typing would have actually done anything.
I think the problem is caused by the update popping up before the working set is restored, so the editor grabs focus from the dialog after the dialog is shown. (Not sure how it breaks the shield visuals, though -- especially since some sort of invisible shield is still clearly in place).
if (_buildNumber === 0 && !force)block (lines 275-278) -- so the block inside never runsif (force || allUpdates[0].buildNumber > _lastNotifiedBuildNumber)test (line 294) -- so the block inside always runsforce = true;at the top of checkForUpdate().Result:
Update notification dialog appears but there's no dark gray "shield" behind it.
Blinking cursor is still in the editor area, and if you type it will modify the editor.
However, clicking/scrolling anywhere is still blocked, along with editor shortcuts like Ctrl+D or Ctrl+Z.
Hitting Esc still closes the dialog, but hitting Enter does not.
Expected:
Gray shield and all keystrokes go only to the dialog, same as if you show it via Help > Check for Updates.
I think the typing still working & the missing shield are both regressions due to PR #4714. Older builds may have shown a blinking cursor in the editor still, but I don't think typing would have actually done anything.
I think the problem is caused by the update popping up before the working set is restored, so the editor grabs focus from the dialog after the dialog is shown. (Not sure how it breaks the shield visuals, though -- especially since some sort of invisible shield is still clearly in place).