Unit Test Failing: ExtensionManager

[redmunds]

Latest master. Both Windows and Mac.

Unit > ExtensionManager
"should open links in the native browser instead of in Brackets"

Error: Expected spy openURLInDefaultBrowser to have been called with [ 'https://github.com/someuser' ] but it was never called.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toHaveBeenCalledWith (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/spec/ExtensionManager-test.js:838:67)
    at jasmine.Block.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1832:18

[redmunds]

Assigning to @dangoor

[peterflynn]

I'm guessing #4718 -- @jasonsanjose, what do you think?

[peterflynn]

It might just be that the simulated click in the unit test doesn't feed into the new global click handler in brackets.js, because it's not known to jQuery (since it still doesn't support registering capture handlers).

It's possible to simulate DOM events more directly -- see SpecRunnerUtils.simulateKeyEvent(). We might need to do something like that...

[peterflynn]

CC @TomMalbran too

[redmunds]

I used git bisect to confirm that @peterflynn is correct. This was introduced by #4718.

[pthiess]

@redmunds assigned this back to you to regress

[redmunds]

Confirmed.