Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

ModalBar should enforce singleton-ness #6203

@peterflynn

Description

@peterflynn

Various parts of our UI code assume only one ModalBar instance can be open at a time (e.g. using selectors like ".modal-bar .foo" to find pieces of UI). However, Nothing globally tracks ModalBar instances; they only show/hide because of blur events, and often only the ModalBar clients even keep track of those events. They also may animate closed or close on a hack timeout (ahem, QuickOpen) -- which means two ModalBars can briefly be open at the same time. This breaks those assumptions.

I'd like to do a cleanup at some point where we (a) eliminate the QuickOpen hacks, (b) use autoClose in more cases, and (c) let ModalBar keep track of its own instances so it can close the previous instance synchronously before opening a new one. This is a placeholder bug for those changes.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions