Should place extensions to update on top of "installed" list

[marcelgerber]

Currently when there are updates to extensions available in the installed list, they are still sorted alphabetically. It would be much better if the extensions to update where the first ones:

• primary order: update available
• secondary order: alphabet

Screen:

The second extension to update is out of view.

I'd try to get a PR ready as soon as I got your ok.

[peterflynn]

@SAplayer Yeah, I think that's a great idea!

[pthiess]

@SAplayer - I assign it to @dangoor but it would be great if you could start working on this great improvement.
Thanks a ton!

[marcelgerber]

Sorry, I tried this, but I didn't get far as the .updateAvailable flag is set later on (async).
Does anybody else want to do this?

[TomMalbran]

@SAplayer I was checking the code and each item is rendered in ExtensionManagerView.prototype._renderItem which is called in ExtensionManagerView.prototype._render or in the change events. So I was thinking, what about appending to the top of the table on render when the extension has an update and moving the item to the top of the table after a change when the extension has an update?

[peterflynn]

I think by the time modelInitPromise has resolved in ExtensionManagerDialog._showDialog(), the objects will be fully populated and safe to sort.

I've always found it a little weird that InstalledViewModel happens to depend on RegistryViewModel loading to mix in some extra info to its objects, and isn't really fully initialized until that happens. If we wanted to be ambitious we could go as far as cleaning that up a bit as part of this work :-) But certainly not required.

[marcelgerber]

@TomMalbran No, these functions are only affecting the Available view, not Installed.
The installed extensions are sorted in InstalledViewModel.prototype._sortFullSet, but the .updateAvailable tags are not yet set when this is called.
We'd have to re-sort this view as soon as the registry data was set and re-render everything afterwards.

@peterflynn It would be a lot easier if we did this work before doing this. But I can't do it as I'm not used to Async stuff and things like Deferred objects and so on.

[larz0]

+1 👍

[marcelgerber]

@zaggino fixed this. Thank you!
Closing.