[cmv4] Esc shouldn't cancel selection if it's handled by other UI

[njx]

1. Make a multiple selection
2. Cmd-F or Cmd-Shift-O
3. Hit Esc

Result: Modal bar is dismissed, but selection also collapses to single selection. It should only collapse if some other UI hasn't already handled the Esc key. This happens with inline editors too.

[njx]

To me

[njx]

/cc @redmunds - I'll look at this one since it's multiselection related.

[njx]

Actually, the inline editor case is different. Probably in that case what we need to do is see if there's a multiple selection in the current focused editor, and if so cancel it; if not, then close the inline editor(s). Filed that as #6967.

[njx]

Also, there are two different cases here that are actually unrelated - they just both happen to involve ModalBar, and neither of them actually have to do with the Esc key handling in Editor.

In the case of Find, it explicitly changes the selection as soon as it's opened - either because of a call to findNext() (if the query was auto-populated), or because there's no search text and it wants to reset the pos (if the query was not auto-populated). The former seems arguably correct, the latter seems questionable. @peterflynn might want to weigh in on what the expected behavior should be with multiple selections here.

In the case of Quick Open, it's due to the fact that we try to reset the selection on close, but we're only looking at the primary selection. This is easy to fix.

[njx]

@peterflynn - ping on this - see previous comment

[redmunds]

Confirmed. Closing.