Rapidly disconnect/reconnect Live Preview causes error message

[ingorichter]

I was able to reproduce this by clicking the Live Preview icon multiple times in a row.
After 4-6 disconnect/reconnect cycles the error message showed up and in the console there was a log entry Inspected frame has gone Object {code: -32000, message: "Inspected frame has gone"}

I tested this on OSX 10.9.2 with a Brackets build based on #6889 and Chrome 33.0.1750.117 beta.

[ingorichter]

Here is a short video showing the behavior https://www.dropbox.com/s/j0sx5q57mczz7l8/LivePreviewError.mov

[peterflynn]

@njx and I have seen people double-clicking the Live Preview icon to launch it, and then doing it again if it didn't launch quickly enough -- so it's definitely plausible to hit this in real world usage.

[redmunds]

@njx @peterflynn @jasonsanjose I was thinking about a couple potential solutions:

1. Simply ignore clicks on Live Preview button, menu, etc. when in a connecting or disconnecting state.
2. Another option would be to implement 1, but also keep a "pending toggle" flag to keep track of when button was clicked in a connecting or disconnecting state. As soon as a connected or disconnected state was reached, then check flag to see if Live Preview should be toggled. (Second thoughts: I originally thought this would be slightly more sophisticated that 1, but the more I think about it this might not lead to desired result).

Let me know what you think about either of these options, or if anyone had another solution in mind.

[peterflynn]

@redmunds I like doing the simplest thing as a first cut: just ignore clicks while it's already in progress.

Even if we think there might be bug cases where it would get stuck in that state forever without timing out, making the button dead until Brackets is restarted, it seems like the button would already have broken behavior in those bug cases... so this couldn't make it much worse. If we're not confident those cases are rare, we could always add a tooltip ("Live Preview is still connecting...") or something so it's evident to users that it's in a sort of paused state.

[jasonsanjose]

FBNC @ingorichter see #7049