When renaming file, exclude file extension from initial selection

[Denisov21]

I wish in Brackets if you renamed a file when the underline only the file name.
Now

wish (Renaming the file)

[peterflynn]

Great idea! I'm not sure if the jsTree code makes it tricky to control selection, but I'm betting this bug' for someone to implement. Marking 'starter bug' tentatively.

[Robo210]

jsTree's API doesn't to allow you to control the selection, but it's doable if you are willing to take a dependency on jsTree's internal workings.

In ProjectManager.js - renameItemInline(...) you can add something to the effect of

$selected.children(".jstree-rename-input")[0].setSelectionRange(0, indexOfExtension);

after the call to _projectTree.jstree("rename");.

This doesn't seem like a very good or future-proof fix, but as far as I can tell it's the only solution. I'll submit a pull request if somebody disagrees with this assessment, but I wouldn't advise it.

[le717]

Is it me, or is Bracket's version of jsTree stuck in the "dark ages"? It seems an (admittedly modified) version of jsTree 1.0-rc3 from 2011 is being used. jsTree is now on 3.0b9, and it looks like it now has an API for renaming files. Perhaps an (thoroughly thought-out 😉) update to jsTree would make this request possible? (Just my two cents, @Robo210's fix, though it may work, seems quite hacky, and would instantly break if jsTree were ever updated.)

[Robo210]

I don't disagree that the version is quite old, but I don't think the new API offers a fix for this issue. The "rename_node" function does the same thing as the "set_text" function that Brackets is using currently, and is also available in the old version as well.

If the version of jsTree that Brackets is using has been modified, would it be acceptable to modify it further to take an optional selection range parameter on the rename function? Perhaps the focus should be to get jsTree upstream to officially expose something like that?

[peterflynn]

It might be simpler to just grab the DOM node after making the rename call, and adjust the selection on it after the fact.

[peterflynn]

Clarified title (was "I wish in Brackets optimization renaming files")

[zaggino]

Fixed in #7209