Should case sensitive toggle should be remembered when find bar is closed?

[njx]

1. Create a document with a word that appears in different cases (e.g. "foo" and "Foo")
2. Cmd-F
3. Type "foo" and turn on case sensitivity
4. Hit Cmd-G a few times - only lowercase "foo" is found
5. Hit Esc to dismiss find bar
6. Hit Cmd-G some more

Result: Both "foo" and "Foo" are found. This seems incorrect. Other editors like TextMate and Sublime remember the case-sensitivity attribute. (In fact, they seem to treat that as a global flag - not just something for the current query; so if you do another search without opening the find dialog again, it will still pay attention to however that checkbox is set from the last time you used the dialog.)

[njx]

This came up when I was implementing the Add Next Match feature for multiselect. Currently, it's only implemented as case-insensitive, because I wasn't thinking that we'd have a way to control it. But because ST treats case-sensitivity as a global flag, it uses its value in its version of Add Next Match, even if the find bar isn't visible. I'm a little worried that relying on that hidden state might be confusing...but on the other hand it seems to be pretty standard.

@peterflynn and @larz0 - thoughts? If we did want to go this route, it should be relatively easy to implement - we would just need to look at the view state instead of the UI element itself when doing any query.

[redmunds]

I agree that it should be remembered.

It seems to only be broken for "Find Next" when the "Find" dialog is not shown. If I Invoke "Find" again, the setting is remembered.

[njx]

Yeah, the issue is when the Find dialog isn't visible.

[peterflynn]

Yep, agreed -- silly oversight on my part. To me, hopefully can sneak this into the current sprint.

[njx]

I think I can see the fix - it looks like a one-line change to me. I'll put up a PR for you to look at.

[njx]

Fixed, closing.