[prefs] Executing unit tests changes Brackets preference settings

[redmunds]

I'm not sure where it happens, but when unit tests are run, the current set of prefs are saved and then restored when tests are complete. This is so tests came change prefs as necessary without altering current prefs in editor.

The problem is that the prefs are getting restored to something other than my current prefs. I suspect that with the new prefs system, prefs are getting "restored" correctly, but what's getting "saved" is not the latest prefs.

[RaymondLim]

@redmunds Can you give an example of which preference settings being altered? Actually, I see the other way around. If I change indentation in Brackets main window to TabSize: 2, then one of the Editor unit tests will fail, indicating that the user pref is affecting the pref used for unit tests.

[redmunds]

I am aware of (but still annoyed with) the problem where all prefs are sometimes lost when certain unit tests fail, but this is a little different. The case I'm seeing is that the files in Working Set, Project Tree state, and selection in files revert back to settings from several minutes ago.

[redmunds]

I think losing prefs when tests fail is bad because affects the main workflow for TDD -- write tests first, run them to verify that they fail, then write code to make tests pass.

[njx]

To @dangoor, medium priority.

[redmunds]

I think I figured out what was happening for one of the cases for this one. My new lenovo laptop is high DPI, so I have Brackets editor zoom at +2.

Recipe:

1. Open Brackets
2. View > Increase Font Size (2 times)
3. Open a file with 500 lines or so and put selection at end of file
4. Shutdown and restart Brackets

Results
Same file is re-opened, cursor position is restored, zoom is restored to +2, and page is scrolled down, but it's not scrolled all the way to where cursor is. Seems that the combination of zoom + font-size needs to be coordinated better.

Let me know if I should split this into a separate issue.
UPDATE: Issue #7093 was created for this.

[dangoor]

@redmunds That does sound like a separate issue, since this issue just tracks making it so that running unit tests doesn't alter the user's prefs.

[dangoor]

I haven't personally seen the tests overwriting my prefs, but this basically put the same change in place for the SpecRunner window that I had done for the separate test window.

[redmunds]

Related issue: #972

[dangoor]

Cool. Thanks for the link to the (really) old bug! I'll make sure that's fixed too.