Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Integration tests fail #7277

@JeffryBooher

Description

@JeffryBooher

One of the Integration test for Inline Help Providers because checking the bounds of the popover assumes that the popover is going to be inside the editor when, in fact, it is a child of the window.

        function boundsInsideWindow(object) {
            // For the popover, we can't use offset(), because jQuery gets confused by the
            // scale factor and transform origin that the animation uses. Instead, we rely on
            // the fact that its offset parent is body, and just test its explicit left/top values.
            var bounds = getBounds(object, false),
                editorBounds = getBounds(testWindow.$("#editor-holder"), true);

            return bounds.left >= editorBounds.left   &&
                bounds.right   <= editorBounds.right  &&
                bounds.top     >= editorBounds.top    &&
                bounds.bottom  <= editorBounds.bottom;
        }

This returns false when the popover is on the left or right edge of the editor (happens when you turn word-wrap off and scroll to the end of a really long line then press ctrl+e no help available.)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions