Opening Application Support (or other parent folder of Brackets prefs) breaks Recent Projects

[lkcampbell]

OS: Mac OSX Mavericks

Brackets Version: sprint 37 experimental build 0.37.0-12014 (release abbda8d)

Repro Steps:

1. Open a new project based on a directory that has many, many files in it, enough files to normally fire off the "Error Indexing Files" dialog after you open it as a project.
2. Add and remove a few more projects, and navigate to one of these other projects.
3. Close and restart Brackets.

Expected Results:
Brackets should open to the last project you were in. The list of recent projects should be the same as they were before the restart.

Observed Results:
Recent Projects doesn't work anymore. Any changes made are lost when Brackets restarts. Brackets always opens to the large directory project, even if you remove it from your list of directories.

Work Around:
Deleting the cache and state files resets the project tree to "Getting Started". As long as you avoid opening the really big directories you shouldn't have this problem.

Other Notes:
Also, possibly, "Error Indexing Files" dialog should pop up when opening the directory. Not sure if we got rid of this recently but I don't see it popping up anymore for huge directories.

[peterflynn]

The lack of an "Error Indexing Files" message is a dupe of #6962.

I think @RaymondLim hit the nail on the head with #7300 (so we should probably close one or the other). Having state.json start out under the watch root and then transition to not being under the watch root seems to be the problem -- the FileSystem code has a number of baked-in assumptions that once you unwatch() a subtree, no one holds onto FileSystemEntry objects from that subtree anymore, and the prefs system is breaking that assumption.

CC @dangoor due to the prefs involvement, and @iwehrman in case you have any views on this fun topic ;-)

[lkcampbell]

@peterflynn, okay, so it doesn't have to do with the number of files. It has to do with the fact that I set my User Home directory as the project directory, and state.json is contained in a sub directory of my User folder?

I saw the Error Indexing Files message not popping up and assumed it was the number of files in my User directory, not the directory itself, that was the problem.

If that is the case, I should probably rewrite the title and the repro steps for this problem, or you should just close this issue and focus on #7300 since this issue is a bit misleading as it stands.

[lkcampbell]

Closing as a duplicate of #7300, which has a more accurate description of what is really causing this problem.