Brackets doesn't recognize existing indentation when auto-indenting close braces

[redmunds]

Start with 2 indented lines where there's an unmatched opening brace on first line and no code on second line:

    if (foo) {

Move cursor to beginning of second line (before indentation, not after) and type closing brace }.

Results:
Brackets adds indentation and then adds the brace. Original indentation is left after the closing brace!

    if (foo) {
    }    

Expected:
Resulting code should not have trailing whitespace.

[peterflynn]

Added "...when auto-indenting close braces" to title to clarify when this happens

[redmunds]

Note that same problem happens with any auto closing, so "brace" is used generically here.

[peterflynn]

Yep -- or at least, "electric chars" that can change indent. I think that's only curly braces, square braces, and parens.

[mackenza]

what do you think the proper behavior should be if that 2nd line indent also has text to the right? for instance:

    if (foo) {
    // this is a comment

so then I enter a } to the left of the indent as per the above testcase and end up with:

    if (foo) {
    }    // this is a comment

I suppose what we want to do is indent and remove whitespace to the right of the closing electric?

[redmunds]

@mackenza I don't think any whitespace should be removed in that case. Since there are non-whitespace chars on line, then it's all visible, so there are no surprises.

[redmunds]

Fix in Progress. Assigning to me while @mackenza works on it.

[redmunds]

Confirmed. Closing.