This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Remove the negative margin hack which is no longer needed#10011
Merged
peterflynn merged 1 commit intomasterfrom Nov 25, 2014
Merged
Remove the negative margin hack which is no longer needed#10011peterflynn merged 1 commit intomasterfrom
peterflynn merged 1 commit intomasterfrom
Conversation
Member
|
Looks perfect -- nice catch, Raymond! |
peterflynn
added a commit
that referenced
this pull request
Nov 25, 2014
Remove the negative margin hack which is no longer needed
Contributor
|
Well this is interesting. While this fixed the issue in CEF 2171, this causes all file tree labels to disappear using CEF from v1.0. Ah, the prices devs pay for running from git. :) |
Contributor
Author
|
@le717 It shouldn't affect the old CEF builds. I did test my changes in old ones. Can you post a screenshot? |
Contributor
|
does not affect me on Mac (v1.0 brackets-shell). |
Contributor
|
@RaymondLim Nevermind, I figured it out. Seems this change broke the |
This was referenced Nov 25, 2014
Contributor
Author
|
@le717 Thanks for catching the issue and reporting it to the extension author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #9965.