This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Highlight scrollbar tickmark for the current Find match#10413
Merged
Highlight scrollbar tickmark for the current Find match#10413
Conversation
the other matches (similar to the text highlighting within the editor). Also, fix a bug where the wrong text highlight color was seen when a file had many search results (> FIND_HIGHLIGHT_MAX) or was too big to searhc for all matches at once (> FIND_MAX_FILE_SIZE): ensure "CodeMirror-searching" is always applied to the current-match highlight, even when other matches aren't highlighted.
prksingh
added a commit
that referenced
this pull request
Feb 10, 2015
Highlight scrollbar tickmark for the current Find match
Contributor
|
@peterflynn Changes look good to me. This would be really useful too :) Merging for 1.2 |
peterflynn
added a commit
that referenced
this pull request
Feb 10, 2015
…tests to verify that search tickmarks are rendered. Also, bump up wait time in WorkingSetView-test that was failing sporadically. The test had zero margin for error on the wait, which may be making it fragile.
prksingh
added a commit
that referenced
this pull request
Feb 11, 2015
Fix unit test that broke due to Find highlighting fix in PR #10413
peterflynn
added a commit
that referenced
this pull request
Feb 13, 2015
…ile-system * origin/master: (180 commits) Update to release 1.3 FR and JP translation fix for index.html file Fix unit test that broke due to a side fix in PR #10413, and enhance tests to verify that search tickmarks are rendered. Only print deprecation warnings for $().on/off() on EventDispatchers once per caller, like other such warnings. Move $() shim into brackets.js normal startup code, since there's no longer any core code that could hit it (only extensions). Fix memory leak in ExtensionManagerViewModel Don't adjust selection if rename fails. Add unit tests for these cases. Fixed typos in docs Update the selected file if a renamed folder is a prefix of the path Use command instead of private method. German Translation Update jQuery -> 2.1.3 Fix for ImageView bug 5960 & 10180 Update README.md Update README.md Update translation Update strings.js Update urls.js Get rid of deprecated calls in LiveDevMultiBrowser Add missing attribute Fixing UX issue of inactive panel getting too dim to read text for dark themes. ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlight scrollbar tickmark for the current Find match differently from the other matches (similar to the text highlighting within the editor: the current match is orange and the other matches are yellow).
Also, fix a bug where the wrong text highlight color was seen when a file had many search results (>
FIND_HIGHLIGHT_MAX) or was too big to search for all matches at once (>FIND_MAX_FILE_SIZE): ensure.CodeMirror-searchingis always applied to the current-match highlight, even when other matches aren't highlighted.I thought this would be a nice enhancement to get into 1.2 :-)