Implement progress callback so node domains are able to notify the Brackets before they finish

[zaggino]

Related PR: adobe/brackets-shell#509
Related Issue: #7356

Please review @nethip , I'd like to get this into Brackets as this would help to improve user experience on some of my work I'm doing with extensions.

[zaggino]

If we don't want to introduce progressCallback as a new argument to node functions, we can make a call callback(null, null, "progress") to invoke a progress and not resolve the promise checking for arguments.length === 3

[nethip]

@zaggino Sure! I will take a look at this.

[zaggino]

The more I'm thinking about this, the more callback(null, null, "progress") version makes sense, but I'll wait for some opinions before fixing this PR.

[nethip]

@zaggino Sorry. I could not find some time to go through this PR as I was caught up with lot of other stuff. I will for sure take a look at this PR next week.

[zaggino]

So I'm guessing nobody found time to review this for 1.3 ...

[nethip]

Yes @zaggino That is right. Sorry for not being able to dedicate some time to this PR in this release.

[zaggino]

Can we get someone to merge this into 1.4?

[abose]

@zaggino I ran the Live preview test for Node connection and the test is timing out at should receive progress events from asynchronous commands [win 8.1]. Any idea why?

[prafulVaishnav]

@abose Have you taken shell changes also? adobe/brackets-shell#509

[abose]

oh! i didn't that explains. Did you verify this change?

[abose]

Verified, merging.
The corresponding PR adobe/brackets-shell#509 in brackets shell has been merged.
Our linux builds will not pick up this change on brackets shell as we build from the older CEF branch.
So will need to manually add this before release. Adding to release 1.4 checklist #11256 .

[nethip]

This is going to make @zaggino to see this once he is back from vacation 😄

[zaggino]

Thanks a lot guys for merging this 👍