This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix #13274 - make Brackets margin/padding remoteHighlight work like Chrome one#13297
Merged
swmitra merged 2 commits intoadobe:masterfrom Apr 24, 2017
Merged
Conversation
Contributor
|
The issue which I mentioned in the last PR is resolved now. |
Contributor
Author
|
@swmitra what do you think? |
Collaborator
|
It seems to be working fine 👍 |
swmitra
approved these changes
Apr 24, 2017
Collaborator
swmitra
left a comment
swmitra
left a comment
There was a problem hiding this comment.
Tested the feature manually. Working fine for different scenarios I have tested. Changeset seems good to me.
Collaborator
|
Good work worie 👍 |
Collaborator
|
@Worie I am working on the same set of files for some other feature. I will refactor it in my PR 😄 |
Contributor
Author
|
Awesome! I'm glad it turned out ok, feel free to ping me if necessary :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for
transform-originand fixed the way of showingborderin highlight div.This contains a little bit more of changes than the previous one and probably will need a bit of refactor, but it should work. Please mention me if it isn't working for some sets of properties and provide the piece of code that does not look correct.
I've tested/developed it on OSX Sierra 10.12.4, Chrome 57.0.2987.133 (64-bit)