This repository was archived by the owner on Sep 6, 2021. It is now read-only.
On Windows force a 32 bit build until nodejs 64 bit is supported#13384
Merged
ficristo merged 1 commit intoadobe:masterfrom Aug 5, 2017
Merged
On Windows force a 32 bit build until nodejs 64 bit is supported#13384ficristo merged 1 commit intoadobe:masterfrom
ficristo merged 1 commit intoadobe:masterfrom
Conversation
petetnt
approved these changes
May 24, 2017
Collaborator
petetnt
left a comment
petetnt
left a comment
There was a problem hiding this comment.
Changeset LGTM, what's stopping us from using the 64bit NodeJS?
Collaborator
Author
|
AFAIK automation doesn't have 32bit builds (see also adobe/brackets-shell#595) and we don't support win64 shell builds (#12814). |
Collaborator
Author
|
@petetnt did you test this on Windows? |
Contributor
|
@ficristo I tested it on MAC, it is working for some extensions, but failing for Brackets Terminal X |
Collaborator
Author
|
What is the error ? |
Collaborator
Author
|
I tryed this branch on Linux and I was able to install some extensions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Brackets doesn't support nodejs 64 bit, I needed to force to compile my extension to 32 bit by adding a .npmrc file with the right flags.
But with that, users on unix platform cannot install the extension from the extension manager anymore.
Adding those flags directly in Brackets should let me remove the .npmrc file.