Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Problems panel: add an icon per problem to tell which type it is #13430

Merged
swmitra merged 1 commit into from
Jun 28, 2017
Merged

Problems panel: add an icon per problem to tell which type it is #13430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/htmlContent/problems-panel-table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<tbody>
{{#reportList}}
<tr class="inspector-section">
<td colspan="3">
<td colspan="4">
<span class="disclosure-triangle {{#isExpanded}}expanded{{/isExpanded}}"></span>
<input type="hidden" value="{{providerName}}" />
{{providerName}} ({{results.length}})
Expand All @@ -11,6 +11,9 @@
{{#results}}
<tr class="{{display}}">
<td class="line-number" data-character="{{pos.ch}}">{{friendlyLine}}</td>
<td class="line-icon">
<div class="line-icon-default line-icon-{{type}}"></div>
</td>
<td class="line-text">{{message}}</td>
<td class="line-snippet">{{codeSnippet}}</td>
</tr>
Expand Down
24 changes: 24 additions & 0 deletions src/styles/brackets.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,9 +2108,33 @@ textarea.exclusions-editor {
text-align: right; // make line number line up with editor line numbers
}

.line-icon {
vertical-align: middle;

.line-icon-default {
width: 20px;
height: 18px;
background-image: url(images/topcoat-inactive-15.svg);
background-repeat: no-repeat;
background-position: 0px 1px;
}

// Add an image based on the type of the problem.
.line-icon-problem_type_error {
background-image: url(images/topcoat-error-15.svg);
}
.line-icon-problem_type_warning {
background-image: url(images/topcoat-warning-15.svg);
}
.line-icon-problem_type_meta {
background-image: url(images/topcoat-inactive-15.svg);
}
}

.line-text {
white-space: nowrap;
width: auto;
padding-left: 5px;
}

.line-snippet {
Expand Down
⚡