Conversation
| prepareServerPromise | ||
| .done(function () { | ||
| WebSocketTransport.createWebSocketServer(PreferencesManager.get("livedev.wsPort")); | ||
| var wsPort = PreferencesManager.get("livedev.wsPort"); |
There was a problem hiding this comment.
Any reason not to use a different pref instead, such as livedef.enableReverseInspect
There was a problem hiding this comment.
@petetnt IMO, that might confuse a lot of users. Instead if an invalid port (0) is given by the user, it's implicit to assume that reverse inspect is not required.
There was a problem hiding this comment.
My 2 cents is that average user doesn't even know what a port is, even without considering what might be an invalid port and what isn't 🤔
There was a problem hiding this comment.
I am a pendulum now 😃 . I had asked the same initially to @saurabh95 but somehow got convinced with the explanation. But now I am convinced by your explanation again so would ask the author to include a new preference. @saurabh95 over to you...
There was a problem hiding this comment.
Yeah, for a user who is not aware of ports, it would be a difficult way to disable reverse inspect. I will add a new preference and will update this PR only.
|
@petetnt Can you please have a look at the new pref? I have to merge this PR today and get the localized description strings as well. |
|
Great work @saurabh95 and @petetnt 👍 |
swmitra
changed the title
3 participants
Fixes: #13307