Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

bug on find solved#13955

Merged
nethip merged 4 commits intoadobe:masterfrom
TrocaTudo95:bug_find
Jan 11, 2018
Merged

bug on find solved#13955
nethip merged 4 commits intoadobe:masterfrom
TrocaTudo95:bug_find

Conversation

@TrocaTudo95
Copy link
Copy Markdown
Contributor

@TrocaTudo95 TrocaTudo95 commented Dec 4, 2017

I solved the issue #13890 . The problem was that when the find bar is opened the function that gets the inital query only was getting the last typed text or a keyword selected and never a word that was searched without typing, now the problem is solved.

@TrocaTudo95
Copy link
Copy Markdown
Contributor Author

any feedback please?

Copy link
Copy Markdown
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍 @TrocaTudo95!

@swmitra
Copy link
Copy Markdown
Collaborator

swmitra commented Jan 4, 2018

@petetnt @nethip Can you please have a look at this change?

@nethip
Copy link
Copy Markdown
Contributor

nethip commented Jan 5, 2018

Thanks @TrocaTudo95. Is it OK to squash and merge this change?

@nethip nethip merged commit ec7dfa3 into adobe:master Jan 11, 2018
@nethip
Copy link
Copy Markdown
Contributor

nethip commented Jan 11, 2018

Thanks @TrocaTudo95

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants