Conversation
…ibility features in hint providers
petetnt
left a comment
There was a problem hiding this comment.
Not sure if this should be a Event Emitter instead?
Documentation would be nice to the userguide.
|
Thanks a lot @petetnt for quick review :+1. This would be a provider specific implementation. IMHO, scoping the event emitter to a provider will make the listener code ambiguous. Also, keeping this as a hook keeps the reach of the handling very shallow and declaration of the intent is upfront. But that's my thought, want to hear the advantages of event emitter in this case as well. |
|
FWIW I am okay with this not being an event emitter too as code hint list providers provide functions anyway now that I looked at this more 👍 |
|
@nethip @petetnt Added this to our wiki for code hint API's. |
|
Thanks @swmitra |
|
Thanks @nethip 😃 |
This PR is targeted to add an optional
onHighlighthook handling for Code hint providers. This will help extension developers to add interactive workflows when a user crawls over hint items in hint popup.@nethip @petetnt All yours now, please have a look at the change set.