This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Conversation
Collaborator
Author
|
@petetnt Thanks a lot for the quick review 👍 |
Contributor
|
Thanks for the PR @swmitra. This solves the spec runner case! Is there a possibility to handle the reload case as well? |
Collaborator
Author
|
Thanks for reviewing the PR @nethip 👍 |
Collaborator
Author
|
@nethip While trying to fix this problem in case of Brackets reload, noticed that, it can't be reproduced 😄 |
Collaborator
Author
|
Thank you @nethip 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
testEnvironmentsearch param validation to skiponbeforeunloadregistration if the current brackets window is a test window.@nethip @petetnt Please review.
@vickramdhawal You can use this patch to run tests 😄