This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fixed ExtractToVariable Menu Close Issue due to scrolling#14492
Merged
boopeshmahendran merged 5 commits intoadobe:masterfrom Aug 2, 2018
niteskum:JSRefactorInlineMenuBug
Merged
Fixed ExtractToVariable Menu Close Issue due to scrolling#14492boopeshmahendran merged 5 commits intoadobe:masterfrom niteskum:JSRefactorInlineMenuBug
boopeshmahendran merged 5 commits intoadobe:masterfrom
niteskum:JSRefactorInlineMenuBug
Conversation
boopeshmahendran
approved these changes
Jul 31, 2018
boopeshmahendran
approved these changes
Aug 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @boopeshmahendran for review
For ExtractToVariable If selection range is not in view It scrolls to bring selected text in view, and It triggers scroll event , and scroll event handler closes all dropdown menu.
so to fix this issue. in Mouse Hover listener of Inline Menu, attached a handler to scroll Event, that reopen the inline Menu. If it has been closed due to scrolling triggered Inline Menu Itself.