This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Continued Language API work#2979
Closed
DennisKehrig wants to merge 6 commits intoadobe:masterfrom
Closed
Conversation
…, defineLanguage now returns a promise that resolves once the mode has been loaded and set, instead of returning the language directly. To make things more consistent both within LanguageManager and with the rest of the code base, chaining support has been removed.
…clusively through getters and setters Adjust the unit tests accordingly Added documentation to Language's properties Refined the comment about our special HTML MIME mode Renamed fileExtensionsToLanguageMap to fileExtensionToLanguageMap
Call result.reject in a few places instead of throwing exceptions
Contributor
Author
There was a problem hiding this comment.
The intention may have been to specify that the language should also be null if the mode is null, but so far we return the fallback language to always return a language.
Contributor
Author
|
@jasonsanjose I updated the unit tests, too, in case you want to double check. |
ghost
assigned
Member
|
Oops. Looks like that overlaps with #2978. I'll reconcile your branch after that lands. |
Member
|
@jasonsanjose Should we close this now that #2980 is up? |
Member
|
Closing, see #2980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focuses on #2968 - minus its comments, so far