Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Adding Handlebars file extension .hbs to use html syntax#3699

Merged
jbalsas merged 3 commits intoadobe:masterfrom
tcarlsen:master
May 3, 2013
Merged

Adding Handlebars file extension .hbs to use html syntax#3699
jbalsas merged 3 commits intoadobe:masterfrom
tcarlsen:master

Conversation

@tcarlsen
Copy link
Copy Markdown
Contributor

@tcarlsen tcarlsen commented May 2, 2013

No description provided.

@jbalsas
Copy link
Copy Markdown
Contributor

jbalsas commented May 2, 2013

@tcarlsen Should we also support .handlebars?

@tcarlsen
Copy link
Copy Markdown
Contributor Author

tcarlsen commented May 2, 2013

@jbalsas to be honest I did't realize that people was using that extension ??? hbs is so sort and good looking, byt if many people is using the longer extension version, when yes it should be added

@jbalsas
Copy link
Copy Markdown
Contributor

jbalsas commented May 2, 2013

I was just curious, since I've seen it mentioned in some tutorials, mostly in reference to precompiling templates. (http://handlebarsjs.com/precompilation.html) This is just a convention, so we may well ignore it, but it would look weird if we support one but not the other.

Would you like to add it?

@ghost ghost assigned jbalsas May 2, 2013
@jbalsas
Copy link
Copy Markdown
Contributor

jbalsas commented May 2, 2013

@tcarlsen This looks good, but it breaks one test in test/spec/LanguageManager-test.js. It should be fairly easy to fix, and then we're good to go :)

Btw, new commits do not trigger the email notifications, so make sure to ping whoever's reviewing your pull requests to let him know that there's new stuff to look into.

@tcarlsen
Copy link
Copy Markdown
Contributor Author

tcarlsen commented May 3, 2013

sry @jbalsas for forgetting the test. Now its here and I did run a test me self and all is good :)

@jbalsas
Copy link
Copy Markdown
Contributor

jbalsas commented May 3, 2013

No problem, @tcarlsen! Looking good now, thanks!

Merging

jbalsas added a commit that referenced this pull request May 3, 2013
Adding Handlebars file extension .hbs to use html syntax
@jbalsas jbalsas merged commit 3b51c65 into adobe:master May 3, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants