This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix for Issue 3891: Extension name and description should be selectable#4284
Merged
njx merged 2 commits intoadobe:masterfrom Jun 20, 2013
Merged
Fix for Issue 3891: Extension name and description should be selectable#4284njx merged 2 commits intoadobe:masterfrom
njx merged 2 commits intoadobe:masterfrom
Conversation
ghost
assigned
|
Looks good, but we should also make the cursor over the selectable text be an I-beam so people know they can select it. Could you add that? BTW, re you running some kind of whitespace cleanup plugin? I don't think it's a big deal, but it would be nice to avoid all the diffs for empty lines. (We do like getting rid of trailing whitespace on non-empty lines, but for empty lines it's not really important.) |
Contributor
Author
|
@njx Added the cursor. |
|
Looks good, thanks. No need to fixup the whitespace...in the future, though, it would be good to turn off the whitespace cleanup for blank lines. Merging. |
njx
pushed a commit
that referenced
this pull request
Jun 20, 2013
Fix for Issue 3891: Extension name and description should be selectable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3891
changes are on line 590 and 596