This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Conversation
Contributor
There was a problem hiding this comment.
Should this be applied to all the platforms?
Member
Author
There was a problem hiding this comment.
No it shouldn't. It already looks like that on Mac and @jasonsanjose is working on the Windows scrollbar that'll look more like the scrollbar on Windows 8.
Contributor
There was a problem hiding this comment.
I mean just the height: 100% property which was applied to the body, and therefor all the platforms, before this change.
And yay on the coming windows custom scrollbars.
Member
Author
There was a problem hiding this comment.
Ahh yes. I need to change that.
ghost
assigned
Merged
Member
|
Closed and squashed in #5083 |
This was referenced Aug 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #4884