Update german samples#5583
Conversation
There was a problem hiding this comment.
Should we translate this into german, too?
|
@ingorichter Have you taken a look on this? |
|
@SAplayer Danke! |
There was a problem hiding this comment.
Sorry for the belated drive by, but I think namhafter is not good German. I'd say "Ein entscheidender Unterschied" or "Ein wichtiger Unterschied"
There was a problem hiding this comment.
I agree it sound a little old fashioned i would choose "Ein entscheidender Unterschied"
There was a problem hiding this comment.
I just pushed commit ae102ce, so I would like you to review. As soon as we're ready, I will create a PR for that.
Please take a look at this commit, too.
Yes, maybe we should change something. But |
|
To be clear I'm not blaming anyone, except myself for not raising my feelings earlier just a little bit -:) I'm actually very appreciative to all your individual as well as generally all contributions which made it into the project. Best, |
|
I just pushed commit ae102ce, so I would like you to review. As soon as we're ready, I will create a PR for that. |
There were some changes to the english samples, so I translated it into german.
Sometimes it's a pretty literal translation, sometimes not - it isn't always easy as we miss some words.
For review: @ingorichter @pthiess @couzteau