This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Adding condition for skipping symlinks when installing extensions via th...#5919
Merged
dangoor merged 1 commit intoadobe:masterfrom Dec 4, 2013
MiguelCastillo:master
Merged
Adding condition for skipping symlinks when installing extensions via th...#5919dangoor merged 1 commit intoadobe:masterfrom MiguelCastillo:master
dangoor merged 1 commit intoadobe:masterfrom
MiguelCastillo:master
Conversation
… the extension manager When installing extensions that have symlinks via the extension manager, they will fail with a message regarding an invalid zip file. This can be tested with https://github.com/MiguelCastillo/Brackets-SymbolicLinks
Contributor
Author
|
This is for issue #5897 |
ghost
assigned
Contributor
|
I wonder if just skipping the symlinks will cause problems with the extensions. I need to see what is symlinked. The latest version of decompress-zip allows you to copy symlinked files. |
Contributor
|
oh, I see. It looks like npm links script files, which is not relevant for Brackets. This is probably a safe approach. |
Contributor
|
👍 |
|
Great work! |
dangoor
added a commit
that referenced
this pull request
Dec 4, 2013
Contributor
|
I added a test and merged this. Thanks, Miguel! |
Contributor
Author
|
You are welcome Kevin :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...e extension manager
When installing extensions that have symlinks via the extension
manager, they will fail with a message regarding an invalid zip file.
This can be tested with
https://github.com/MiguelCastillo/Brackets-SymbolicLinks