This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix #6142. Check for the argument name to be falsy#6143
Merged
RaymondLim merged 1 commit intoadobe:masterfrom Dec 2, 2013
Merged
Fix #6142. Check for the argument name to be falsy#6143RaymondLim merged 1 commit intoadobe:masterfrom
RaymondLim merged 1 commit intoadobe:masterfrom
Conversation
In some cases (see adobe#6142 for a minimized testcase), the argument name is returned as null instead of undefined as the code expects. This fix simply changes to check for name to be falsy (in which case it will be assinged a generated name).
ghost
assigned
Contributor
|
Looks good! Merging. |
RaymondLim
added a commit
that referenced
this pull request
Dec 2, 2013
Fix #6142. Check for the argument name to be falsy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases (see #6142 for a minimized testcase), the argument name is
returned as null instead of undefined as the code expects. This fix
simply changes to check for name to be falsy (in which case it will be
assinged a generated name).