added pointer-events to CSS Code Hints#6156
Conversation
ghost
assigned
|
Looks good. Merging. |
added pointer-events to CSS Code Hints
|
rock on, Thanks! |
There was a problem hiding this comment.
One small nit: The properties are not alphabetically sorted.
There was a problem hiding this comment.
ahh, thanks for catching that. I just added them in order listed on the MDN
https://developer.mozilla.org/en-US/docs/Web/CSS/pointer-events
Would you want me to submit another PR with them alphabetized? I'm happy to do so.
There was a problem hiding this comment.
Yes please. All the other properties values are alphabetized.
There was a problem hiding this comment.
@TomMalbran Fwiw, I'm pretty sure the order doesn't matter (other than for code cleanliness)... afaict the only place this is consumed is in CssPropHints.getHints(), which sort()s the array before use -- see line 255. (And in the future even that probably won't matter because we'll eventually be re-sorting the results based on StringMatch ranking).
There was a problem hiding this comment.
But maybe it's easier to see if a propertie value exists when you look for it.
There was a problem hiding this comment.
Yes, we are sorting them to easily find if a property value exists.
5 participants
No description provided.