Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix remaining cmv4 FindReplace unit tests#6773

Merged
njx merged 2 commits intocmv4from
randy/cmv4-find-tests
Feb 6, 2014
Merged

Fix remaining cmv4 FindReplace unit tests#6773
njx merged 2 commits intocmv4from
randy/cmv4-find-tests

Conversation

@redmunds
Copy link
Copy Markdown
Contributor

@redmunds redmunds commented Feb 5, 2014

Fixed 2 issues:

  1. DOM structure changed slightly, so test was not building matching array correctly. Used a safer search.
  2. Another case where call to Editor.getCursorPos() was missing first param.

cc @njx

@njx
Copy link
Copy Markdown

njx commented Feb 6, 2014

Argh, I really screwed up when I replaced the getCursor() calls with getCursorPos() calls. I'll take a quick look to make sure I didn't miss any other similar cases.

@njx
Copy link
Copy Markdown

njx commented Feb 6, 2014

OK, I think that was the only other case I missed. Sorry about that.

@njx
Copy link
Copy Markdown

njx commented Feb 6, 2014

Looks good, merging.

njx pushed a commit that referenced this pull request Feb 6, 2014
Fix remaining cmv4 FindReplace unit tests
@njx njx merged commit 1d25556 into cmv4 Feb 6, 2014
@njx njx deleted the randy/cmv4-find-tests branch February 6, 2014 00:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants