Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Update inspector protocol JSON to M31 branch 1650#7010

Merged
redmunds merged 2 commits intomasterfrom
jasonsanjose/prototcol-M31-branch-1650
Nov 19, 2014
Merged

Update inspector protocol JSON to M31 branch 1650#7010
redmunds merged 2 commits intomasterfrom
jasonsanjose/prototcol-M31-branch-1650

Conversation

@jasonsanjose
Copy link
Copy Markdown
Member

@JeffryBooher
Copy link
Copy Markdown
Contributor

assigning to @redmunds

@jasonsanjose
Copy link
Copy Markdown
Member Author

This PR is not required for the other sprint 37 live preview bugs.

@dangoor
Copy link
Copy Markdown
Contributor

dangoor commented May 20, 2014

I think this is low priority, since it doesn't solve any current bugs. Does that seem reasonable?

@redmunds
Copy link
Copy Markdown
Contributor

@jasonsanjose Sorry for letting this languish. I thought we wouldn't be needing it with new Live Preview, but I'm not sure if that's true. Is this PR still good to merge?

@redmunds
Copy link
Copy Markdown
Contributor

Merging.

redmunds added a commit that referenced this pull request Nov 19, 2014
…-1650

Update inspector protocol JSON to M31 branch 1650
@redmunds redmunds merged commit ec633dc into master Nov 19, 2014
@redmunds redmunds deleted the jasonsanjose/prototcol-M31-branch-1650 branch November 19, 2014 03:40
@redmunds
Copy link
Copy Markdown
Contributor

redmunds commented Dec 5, 2014

Inspector.html needs to be re-generated for the updated API. @jdiehl Do you happen to remember which tools, templates, transforms, etc. that you used to generate this file?

@jdiehl
Copy link
Copy Markdown

jdiehl commented Dec 6, 2014

The script is included in the repository: Simply run ruby jsdoc.rb in brackets/src/LiveDevelopment/Inspect. This will overwrite Inspector.html with the updated documentation.

@redmunds
Copy link
Copy Markdown
Contributor

redmunds commented Dec 8, 2014

@jdiehl Cool, thx! Apparently, the name of that script was not obvious enough for me :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants