Added some unit tests for regression #7086#7244
Conversation
redmunds
changed the title
There was a problem hiding this comment.
is the parameter really necessary since you're always generating 5 dummy projects?
|
@ingorichter Done w/ review. Looks good except for my one comment regarding the unused function parameter. |
|
@bchintx Thank you Bryan. I cleaned up a bit and reused a function that was already available in the SpecRunnerUtils.js |
|
Nice. Changes look great. Merging. |
Added some unit tests for regression #7086
There was a problem hiding this comment.
There is an indentation issue here
There was a problem hiding this comment.
Actually, this is fine, but the rest of the document is using Tabs instead of spaces.
There was a problem hiding this comment.
I was testing something for Raymond a couple of days ago regarding spaces vs. tabs and indentation. This might be a result of this efforts. ;-) let me check and clean it up.
3 participants
Added some unit tests for regression #7086