Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Toned down live highlight decorations#7315

Merged
njx merged 4 commits intomasterfrom
larz/issue-7255
Apr 15, 2014
Merged

Toned down live highlight decorations#7315
njx merged 4 commits intomasterfrom
larz/issue-7255

Conversation

@larz0
Copy link
Copy Markdown
Member

@larz0 larz0 commented Mar 24, 2014

This is for #7255.

@njx
Copy link
Copy Markdown

njx commented Mar 24, 2014

Hmm, that does make it hard to see in something like Citrus. I wonder if a solution would be to start out covering the whole area with a color, but then fade the inside to transparent, so your eye is drawn to the box. Or a sort of "grow/shrink" effect, kind of like what TextEdit does in Find.

@larz0
Copy link
Copy Markdown
Member Author

larz0 commented Mar 24, 2014

@njx could you check again. I tried 1s transition but it's easy to miss it when moving the eye from the editor to browser so I made it 2.3s.

@njx njx self-assigned this Mar 25, 2014
@njx
Copy link
Copy Markdown

njx commented Apr 15, 2014

Oh, this is interesting. I didn't think I would like the long delay when you described it, but it actually seems to work well - it's long enough that you can really see it, but then it fades out quickly enough that it doesn't feel in your way once you actually start making changes. It also seems to work pretty well if you're moving the cursor around quickly (like arrowing around a CSS file through many rules).

I think it could be a tad faster - maybe 2s instead of 2.3s. That seems long enough that you can see it peripherally in the browser, and by the time your eyes move there it's almost faded out.

In any case, whether you want to tweak that, I'm happy to merge this and see what other people think. We can always tweak it later if people think it's too slow.

@njx
Copy link
Copy Markdown

njx commented Apr 15, 2014

(BTW, I would also say that just from a feel point of view, it feels a lot better than the short "flashy" nature of the original highlight.)

@larz0
Copy link
Copy Markdown
Member Author

larz0 commented Apr 15, 2014

@njx awesome! Let's merge this and see what happens. (Took me a while to get 2.3 :)

@njx
Copy link
Copy Markdown

njx commented Apr 15, 2014

OK, I'm good with that. Merging.

njx pushed a commit that referenced this pull request Apr 15, 2014
Toned down live highlight decorations
@njx njx merged commit 92ec6fe into master Apr 15, 2014
@njx njx deleted the larz/issue-7255 branch April 15, 2014 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants