This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix Extension Manager crash when other Bootstrap tabs present in DOM#7559
Merged
Fix Extension Manager crash when other Bootstrap tabs present in DOM#7559
Conversation
*all* Bootstrap tabs in the entire DOM as part of its tab set, so it will crash if any such other tabs exist in the UI. This was the only jQuery call in the Extension Manager code that wasn't scoped down to $dlg (or used an equivalent parent selector).
Contributor
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Apr 17, 2014
Fix Extension Manager crash when other Bootstrap tabs present in DOM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Extension Manager bug: a poorly-scoped jQuery call causes it to see all Bootstrap tabs in the entire DOM as part of its tab set, so it will crash if any other such tabs exist in the UI (leaving the Extension Manager dialog blank).
This was the only jQuery call in the Extension Manager code that wasn't already scoped down to $dlg (or used an equivalent parent selector).