This repository was archived by the owner on Sep 6, 2021. It is now read-only.
More specific error message when non-UTF-8 files opened#7787
Merged
Conversation
… open a file that is not UTF-8 (message is also shown when trying to open binary files). The right error code is already returned from the native shell -- we just need to plumb it down to FileSystem and add a case-specific string for it.
|
Looks fine to me and works on the Mac. Merging. |
njx
pushed a commit
that referenced
this pull request
May 8, 2014
More specific error message when non-UTF-8 files opened
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give a more specific error message in cases where Brackets refuses to open a file that is not UTF-8 (message is also shown when trying to open binary files).
The right error code is already returned from the native shell -- we just need to plumb it down to FileSystem and add a case-specific string for it.
I haven't tested this on Mac but I think this will give us the same benefit there too -- it looks like the same brackets.fs-level encoding error code is returned in the right cases there already. But if not, it's not critical since Mac has always refused to open UTF-8 (whereas for Win it's a new and potentially confusing behavior).