Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Re-create dropdown event handler so that the new rendered list will have highlight on mouse hover.#7980

Merged
bchintx merged 1 commit intomasterfrom
rlim/dropdown-highlight
May 30, 2014
Merged

Re-create dropdown event handler so that the new rendered list will have highlight on mouse hover.#7980
bchintx merged 1 commit intomasterfrom
rlim/dropdown-highlight

Conversation

@RaymondLim
Copy link
Copy Markdown
Contributor

This fixes #7969.

@bchintx Can you review this also? Thanks.

@bchintx
Copy link
Copy Markdown
Contributor

bchintx commented May 30, 2014

Looks good. Merging...

bchintx added a commit that referenced this pull request May 30, 2014
Re-create dropdown event handler so that the new rendered list will have highlight on mouse hover.
@bchintx bchintx merged commit 9e86957 into master May 30, 2014
@bchintx bchintx deleted the rlim/dropdown-highlight branch May 30, 2014 06:21
@njx
Copy link
Copy Markdown

njx commented May 30, 2014

Drive-by: I don't think it's safe to just create a new DropdownEventHandler and discard the old one without doing any cleanup. It looks like the old one does things like register global keydown hooks, mouse events, etc. which should be unregistered before creating a new one. (Even though the old items are going away, the mouse events appear to be attached to the parent through delegation, and the parent isn't getting deleted/recreated.)

Since the parent isn't deleted on re-render, do we know why the highlight behavior was lost? It seems like the mouse handlers should still work.

@njx
Copy link
Copy Markdown

njx commented May 30, 2014

(BTW, this is probably another good reason to unify the DropdownEventHandler and at least the list-management portions of DropdownButton. The current factoring seems weird.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FileFilters] Highlight disappears after deleting a filter

3 participants