Renamed preferences key from "brackets-themes" to "themes" to avoid conf...

[MiguelCastillo]

...lict with the themes extension
#8461

[MiguelCastillo]

cc @dangoor

[TomMalbran]

@MiguelCastillo If the font preferences are no longer under the theme prefix, which preferences are left under it? Do we really need to have a themes prefix or we can just remove it since is a core feature?

[MiguelCastillo]

@TomMalbran I left themes in there because there was no real objection one way or the other from @dangoor when we had a short discussion here #8461.

But if we all think is better to remove the prefix, then let's do it! My preference has always been to scope things in a namespace type of way... Kinda makes it clearer to see what code is doing what.

Fonts settings are still going under that, but the fonts api will have its own "fonts" prefix. Unless of course we don't want that there either.

@dangoor, any preference?

[lkcampbell]

@MiguelCastillo, this comment isn't directly related to this PR, but this looks as good of a place as any to bring this up. Do you need to change the license text at the beginning of these files to match the Adobe licensing text?

[dangoor]

We still have two settings: the selected theme and customScrollbars, so I think putting those under a "themes" prefix is fine.

@lkcampbell The license blocks are fine, I think, since we don't explicitly require copyright assignment (nor is it really necessary with the MIT license).

[dangoor]

Looks fine. Merging