Update themes-settings.html and strings.js#8715
Conversation
Fix adobe#8712 (part 1 of 2)
|
@Denisov21 Please put all of you files in a single pull request. I tried explain this in the Code Review section in this article, but maybe I wasn't clear enough. In you particular case, do this:
|
|
@Denisov21 FYI, I updated the NLS README file with this section: Updating Existing Branch and Pull Request to make this more clear. Let me know if you have any suggestions for improvements. |
|
Yep. We can't merge this without the changes in #8716 being part of the same merge. There's no reason for this to be split into 2 PRs (or even 2 separate commits, really). |
Changes made -- ready for another review
|
@redmunds Sorry for the inconvenience, it was my first PR with two different files. Your explanation is very good! |
There was a problem hiding this comment.
Strings.THEME_SETTINGS does not match what you have defined in strings.js.
|
@MiguelCastillo Changes made -- ready for another review! |
|
This one looks good to be merged. |
Update themes-settings.html and strings.js
|
Thanks @Denisov21! |
Fix #8712 (part 1 of 2)