This repository was archived by the owner on Sep 6, 2021. It is now read-only.
fix InlineImageViewer example extension#9191
Merged
ficristo merged 2 commits intoadobe:masterfrom Oct 30, 2016
Merged
Conversation
Contributor
Author
kidwm
force-pushed
the
fix-InlineImageViewer
branch
from
721db07 to
d1b91d0
Compare
Contributor
|
Good catch. The styles to separate the filename and close button need to be in a stylesheet (not inline). |
Contributor
|
@kidwm Could you move the in line styles to a style sheet? We could then go ahead and merge this change. |
Contributor
Author
|
@nethip I've done it. |
Contributor
|
@kidwm Thanks! I would do a quick round of testing and merge this. |
Collaborator
Collaborator
|
LGTM, ideally the filename could be near the X to match other QuickEdit. @kidwm thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and separate the filename and close button.