Keep query and replace text when switching between Replace and Replace In Files

[marcelgerber]

For #8531

[redmunds]

findBar is already used in module scope, so change it in this inner scope to something like bar to make code easier to read.

[redmunds]

@marcelgerber This looks good. Just a couple minor comments.

[marcelgerber]

I wonder if we should put these lines into FindUtils to reduce code duplication?

[marcelgerber]

@redmunds Could you take another look?

[redmunds]

Since you're only interested in the first non-closed bar, you should use FindBar._bars.some() which quits the loop when first one is found (but filter() unnecessarily continues through entire Array).

[marcelgerber]

I used _.find() as Array.filter will only return a boolean value...

[redmunds]

Cool -- even better. With Array.some(), you have to create a var in outer scope to save item.

[marcelgerber]

... and that's why I didn't use it :D

[redmunds]

@marcelgerber Nice refactoring! Just 1 more comment.

[marcelgerber]

@redmunds Time for the final review

[redmunds]

Looks good. Merging.