This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix scroll position jumping for few cases#9624
Merged
RaymondLim merged 3 commits intomasterfrom Dec 10, 2014
Merged
Conversation
Contributor
Author
|
Check if this also fixes #9629 |
redmunds
changed the title
redmunds
changed the title
Contributor
Author
|
Removing @peterflynn You filed #9547, so do you care to review this one? This was originally tagged for 1.0, so I think we probably want to get this in for 1.1. |
Contributor
|
Looks good! Merging. |
RaymondLim
added a commit
that referenced
this pull request
Dec 10, 2014
Fix scroll position jumping for few cases
peterflynn
added a commit
that referenced
this pull request
Mar 24, 2015
…search-field Reimplements the fixes from PR #9624 & #9153 in a simpler way: instead of trying to selectively suppress ModalBar's scroll pos adjustments, in cases where we need to revert scroll pos in one file, just wait until ModalBar is done adjusting scroll pos and *then* reset the one we care about. Made possible by the fact that we now listen for ModalBar's "close" event and the event passes info on the reason for closing. Removes delay before results list opens: in CEF 2171 it seems both unneeded (animation is smooth without it) and it triggers an apparent Chrome bug where the post-animation state is displayed during the delay period even though the computed style reflects the pre-animation state. Conflicts: src/search/QuickOpen.js src/styles/brackets.less src/styles/brackets_colors.less src/widgets/ModalBar.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #9547 . This bug was exposed by fix for #9037.
May also help #9629
This change fixes these cases:
Ctrl-Shift-Othen click in pageCtrl-Shift-Othen blur editorCtrl-G, type in a line number, thenEnterkeyCtrl-Gthen blur editorCtrl-Tthen blur editorCtrl-Gthen click in pageCtrl-Tthen click in pageVerify that these case are not broken:
Ctrl-Shift-OthenEsckeyCtrl-Shift-O, select same file with arrow keys, thenEnterkeyCtrl-Shift-O, select different file with arrow keys, thenEnterkeyCtrl-GthenEsckeyCtrl-T, select element, thenEnterkeyCtrl-TthenEsckeyNote: "blur editor" can be done by selecting same file in working set
cc @peterflynn